Support for adding scoped CSS without triggering global refresh #1999
Conversation
|
I am happy to resubmit this PR following the above guidelines (I am not entirely sure how to compose the PR title, for example), but would somebody be able to review the code to ensure it's a valid PR otherwise? Many thanks |
Fixed profiling naming inconsistencies Co-Authored-By: Martin Yankov <[email protected]>
Naming consistency fix Co-Authored-By: Martin Yankov <[email protected]>
|
@VladimirAmiorkov This PR depends on NativeScript/NativeScript#7907 , which will be released with {N} 6.2. |
|
test tns_core_modules#next |
|
All checked have passed. This PR is ready for merge once [email protected] is about to be fully released. |
|
@VladimirAmiorkov thanks - does that mean this will go live at roughly the same time as 6.2.0? (edit: I had written the completely wrong question) |
|
@joshcomley Yes this will make it in time for NativeScript 6.2.0. |
|
@VladimirAmiorkov is there an estimated date for the 6.2.0 release? I understand this isn't exactly the thread to ask, but I'm not sure where is! |
|
@joshcomley We are aiming for the end of the month. |
|
test tns_core_modules#next |
As per the problem I reported here:
NativeScript/theme#179
When using component scoped CSS there is no need to trigger a full global refresh of the styles.
This change does not affect performance or function of using
encapsulation: ViewEncapsulation.Noneon a component.This PR goes hand in hand with a modification to
tns-core-modulesto support the below changes.PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].